git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH v2 0/2] negotiator/default: avoid stack overflow

From
Junio C Hamano <gitster@pobox.com>
Date
May 1, 2023, 22:11 UTC
Message-ID
<xmqqildb3dnn.fsf@gitster.g>
In-Reply-To
<cover.1682513384.git.hanxin.hx@bytedance.com>
Han Xin <hanxin.hx@bytedance.com> writes:
Show 6 quoted lines
> This series avoid stack overflow in negotiator/default.c and memory leak
> in negotiator/skipping.c.
>
> Changes since v2:
> * Rewrite the commit link in the typical format.
> * Fix the incorrect check for the COMMON bit introduced in v2.

I see Derrick pointed out a logic error during the review of v2 and this round corrects it. Is everybody happy with this iteration and considers it safe to merge it to 'next'?

Thanks.
Previous: Han XinNext: Derrick Stolee
Message 18 of 20 in “negotiator/default.c: avoid stack overflow”
  1. negotiator/default.c: avoid stack overflowHan Xin, Apr 24, 2023
  2. Derrick StoleeApr 24, 2023
  3. Han XinApr 25, 2023
  4. Derrick StoleeApr 25, 2023
  5. 0/2 negotiator/default: avoid stack overflowHan Xin, Apr 26, 2023
  6. 2/2 negotiator/skipping: fix some problems in mark_common()Han Xin, Apr 26, 2023
  7. Derrick StoleeApr 26, 2023
  8. Han XinApr 26, 2023
  9. 1/2 negotiator/default: avoid stack overflowHan Xin, Apr 26, 2023
  10. Derrick StoleeApr 26, 2023
  11. Han XinApr 26, 2023
  12. 0/2 negotiator/default: avoid stack overflowHan Xin, Apr 26, 2023
  13. 1/2 negotiator/default: avoid stack overflowHan Xin, Apr 26, 2023
  14. Junio C HamanoApr 26, 2023
  15. Derrick StoleeApr 26, 2023
  16. Junio C HamanoApr 26, 2023
  17. 2/2 negotiator/skipping: fix some problems in mark_common()Han Xin, Apr 26, 2023
  18. Junio C HamanoMay 1, 2023
  19. Derrick StoleeMay 2, 2023
  20. Junio C HamanoMay 2, 2023

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.