Re: [PATCH v2 0/2] negotiator/default: avoid stack overflow

From: Derrick Stolee <derrickstolee@github.com>
Date: May 2, 2023, 01:49 UTC
Message-ID: <9ad5f246-e21f-0a13-1a53-1ae3307c3f0e@github.com>
In-Reply-To: <xmqqildb3dnn.fsf@gitster.g>

On 5/1/2023 6:11 PM, Junio C Hamano wrote:

Show 12 quoted lines

> Han Xin <hanxin.hx@bytedance.com> writes:
> 
>> This series avoid stack overflow in negotiator/default.c and memory leak
>> in negotiator/skipping.c.
>>
>> Changes since v2:
>> * Rewrite the commit link in the typical format.
>> * Fix the incorrect check for the COMMON bit introduced in v2.
> 
> I see Derrick pointed out a logic error during the review of v2 and
> this round corrects it.  Is everybody happy with this iteration and
> considers it safe to merge it to 'next'?

Sorry for the lack of confirmation on that. I do think the v3 patches are good (the cover letter says v2).

Thanks, -Stolee