Re: [External] Re: [PATCH v2 1/2] negotiator/default: avoid stack overflow

From: Han Xin <hanxin.hx@bytedance.com>
Date: Apr 26, 2023, 11:40 UTC
Message-ID: <CAKgqsWV==tgyz8EOs61_06+bX4Eq+0Su1bocZ+-s4oe+e0DdJA@mail.gmail.com>
In-Reply-To: <bf45bfe7-4a29-38d6-b8d7-811581aec82b@github.com>

On Wed, Apr 26, 2023 at 7:13 PM Derrick Stolee <derrickstolee@github.com> wrote:

Show 15 quoted lines

>
> On 4/26/2023 12:05 AM, Han Xin wrote:
> > mark_common() in negotiator/default.c may overflow the stack due to
> > recursive function calls. Avoid this by instead recursing using a
> > heap-allocated data structure.
> >
> > This is the same case as [1].
> >
> > 1. 4654134976f (negotiator/skipping: avoid stack overflow, 2022-10-25)
>
> We would typically write this inline, such as:
>
>   This is the same case as 4654134976f (negotiator/skipping: avoid
>   stack overflow, 2022-10-25)
>

Make sense.

Thanks -Han Xin