Re: [PATCH v5 0/8] Repack objects into separate packfiles based on a filter

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 16, 2023, 17:16 UTC
Message-ID: <xmqqil9egb65.fsf@gitster.g>
In-Reply-To: <ZNwaoGBNrpdzlPUq@nand.local>

Taylor Blau <me@ttaylorr.com> writes:

Show 6 quoted lines

> I think that there is a bug lurking in the sense of trying to reuse
> bitmaps when covering a pack that doesn't have reachability closure in
> this particular scenario.
>
> But there are no "blessed" use-cases for doing this. So I think that we
> should indeed fix this, but I am not immediately concerned here.

OK.

> No; we can either reuse a complete bitmap or not. So it's fine to OR
> all of the (permuted) bits into ent->bitmap, but it's not OK to fill in
> just part of them.

Sounds sane.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.