Re: [PATCH 5/9] repack: refactor finishing pack-objects command

From: Taylor Blau <me@ttaylorr.com>
Date: Jun 21, 2023, 11:06 UTC
Message-ID: <ZJLZnS1olivaQ+GH@nand.local>
In-Reply-To: <xmqqilbotgbp.fsf@gitster.g>

On Thu, Jun 15, 2023 at 05:13:14PM -0700, Junio C Hamano wrote:

Show 6 quoted lines

> Computing "is it local?" based on the value of "destination" feels
> it belongs to the caller (one of the callers that do need the
> computation), not to this function, especially given that the full
> value of "destination" is not even used in any other way in this
> function.  And the "is_local?" bit can instead be passesd into this
> helper function as a parameter.

Hah. I had the same suggestion down-thread, but hadn't read your reply yet. There are either a couple of changes we could make to skip_prefix(), or foist the responsibility onto the caller (I tend to prefer the latter).

Thanks, Taylor

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.