Re: [PATCH] imap-send: increase command size limit

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 15, 2024, 18:38 UTC
Message-ID: <xmqqil0impy3.fsf@gitster.g>
In-Reply-To: <ZhwV6CmcC8zeSJ-7@tapette.crustytoothpaste.net>

"brian m. carlson" <sandals@crustytoothpaste.net> writes:

Show 17 quoted lines

>>  ...
>> Suggested-by: Jeff King <peff@peff.net>
>> Signed-off-by: René Scharfe <l.s.r@web.de>
>> ---
>> This time I compiled with NO_CURL=1 and NO_APPLE_COMMON_CRYPTO=1 and
>> verified with a silly printf that the changed code was actually used
>> and wrote the present message to an IMAP folder whose name is 1006
>> characters log, which required a 1026 bytes long APPEND command.  Yay,
>> freedom!
>
> I'm curious, is there a particular problem that you (or someone else)
> ran into that caused you to make this change?  I agree it seems prudent
> in general, but if there's a particular real-world broken case that this
> hits (e.g., mailbox names in a given language), I think the commit
> message would be a great place to mention this real-world impact, which
> would lend support to your argument that this is a valuable change to
> make.

I personally am not curious about real-world problem in this case, but I won't stop you asking ;-)

I view this more about code simplification. We no longer need a custom nfvasprintf() helper nobody else cares about, leaving the resulting code easier to read.

Will queue but will wait for a day or two to see if René wants to add clarification to the proposed commit log message before merging it to 'next'.

Thanks, both.