git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] imap-send: increase command size limit

From
Jeff King <peff@peff.net>
Date
Apr 15, 2024, 18:45 UTC
Message-ID
<20240415184552.GA1709228@coredump.intra.peff.net>
In-Reply-To
<xmqqil0impy3.fsf@gitster.g>
On Mon, Apr 15, 2024 at 11:38:28AM -0700, Junio C Hamano wrote:
Show 18 quoted lines
> > I'm curious, is there a particular problem that you (or someone else)
> > ran into that caused you to make this change?  I agree it seems prudent
> > in general, but if there's a particular real-world broken case that this
> > hits (e.g., mailbox names in a given language), I think the commit
> > message would be a great place to mention this real-world impact, which
> > would lend support to your argument that this is a valuable change to
> > make.
> 
> I personally am not curious about real-world problem in this case,
> but I won't stop you asking ;-)
> 
> I view this more about code simplification.  We no longer need a
> custom nfvasprintf() helper nobody else cares about, leaving the
> resulting code easier to read.
> 
> Will queue but will wait for a day or two to see if René wants to
> add clarification to the proposed commit log message before merging
> it to 'next'.

Yeah, as the suggested-by person, I can affirm that this is not something I saw in real life. I agree the primary motivation is the code simplification, and dropping a pointless limit is the bonus. I'd probably have written it in that style, but I'm OK either way.

-Peff
Previous: Junio C HamanoNext: René Scharfe
Message 4 of 8 in “imap-send: increase command size limit”
  1. imap-send: increase command size limitRené Scharfe, Apr 14, 2024
  2. brian m. carlsonApr 14, 2024
  3. Junio C HamanoApr 15, 2024
  4. Jeff KingApr 15, 2024
  5. René ScharfeApr 16, 2024
  6. Jeff KingApr 15, 2024
  7. René ScharfeApr 16, 2024
  8. Jeff KingApr 17, 2024

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.