git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] sequencer: make it clearer that commit descriptions are just comments

From
Junio C Hamano <gitster@pobox.com>
Date
May 16, 2025, 16:21 UTC
Message-ID
<xmqqikm0wmpl.fsf@gitster.g>
In-Reply-To
<ABFDED43-3AC7-455E-9736-A8D9AC0F3A40@gmail.com>
Ben Knoble <ben.knoble@gmail.com> writes:
Show 12 quoted lines
>> Le 15 mai 2025 à 11:56, Junio C Hamano <gitster@pobox.com> a écrit :
>> 
>> Phillip Wood <phillip.wood123@gmail.com> writes:
>> 
>>>> -        grep -v -e \# -e ^$ work >patches &&
>>>> +        sed -e s/#.*// work | grep -v ^$ >patches &&
>>> 
>>> I think we could just use 'sed -n "!/^#/p work >patches &&" here
>> 
>> Or even "sed -e '/^#/d' -e '/^$/d'" ?
>
> I’m probably missing something obvious, but why step away from "grep -v -e ^\# -e ^$"? A one character change from the original ;) If we must go with Sed, I’d prefer Junio’s construct (combining, with obvious semantics via "d") over the sed|grep pipeline. 

Mine was a spinal reflex against piping sed and grep; I do not see a reason why "grep -v" with two patterns like you gave should not work---that is a good way to remove the pipe, too.

Thanks.
Previous: Elijah NewrenNext: Junio C Hamano
Message 9 of 11 in “sequencer: make it clearer that commit descriptions are just comments”
  1. sequencer: make it clearer that commit descriptions are just commentsElijah Newren via GitGitGadget, May 15, 2025
  2. RetoMay 15, 2025
  3. Phillip WoodMay 15, 2025
  4. Phillip WoodMay 15, 2025
  5. Phillip WoodMay 15, 2025
  6. Junio C HamanoMay 15, 2025
  7. Ben KnobleMay 16, 2025
  8. Elijah NewrenMay 16, 2025
  9. Junio C HamanoMay 16, 2025
  10. Junio C HamanoMay 15, 2025
  11. sequencer: make it clearer that commit descriptions are just commentsElijah Newren via GitGitGadget, May 16, 2025

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.