Re: [PATCH] sequencer: make it clearer that commit descriptions are just comments

From: Elijah Newren <newren@gmail.com>
Date: May 16, 2025, 15:22 UTC
Message-ID: <CABPp-BFKrgB5_rMX=i0t1Dvj2XwEoCS71+QAFY=hcTnyDnOr7Q@mail.gmail.com>
In-Reply-To: <ABFDED43-3AC7-455E-9736-A8D9AC0F3A40@gmail.com>

On Fri, May 16, 2025 at 7:07 AM Ben Knoble <ben.knoble@gmail.com> wrote:

Show 13 quoted lines

>
> > Le 15 mai 2025 à 11:56, Junio C Hamano <gitster@pobox.com> a écrit :
> >
> > Phillip Wood <phillip.wood123@gmail.com> writes:
> >
> >>> -        grep -v -e \# -e ^$ work >patches &&
> >>> +        sed -e s/#.*// work | grep -v ^$ >patches &&
> >>
> >> I think we could just use 'sed -n "!/^#/p work >patches &&" here
> >
> > Or even "sed -e '/^#/d' -e '/^$/d'" ?
>
> I’m probably missing something obvious, but why step away from "grep -v -e ^\# -e ^$"? A one character change from the original ;) If we must go with Sed, I’d prefer Junio’s construct (combining, with obvious semantics via "d") over the sed|grep pipeline.

:-) I made this exact change to make it be a one-character modification of the original, and pushed it up yesterday (https://github.com/gitgitgadget/git/pull/1923); I just hadn't /submit'ted it to the list yet. I agree that every suggestion folks have made so far is better than my original proposal, but I kind of prefer this latest suggestion of just making a one-character modification. So, unless folks object, I'll indeed go with this one.