From: Junio C Hamano <gitster@pobox.com>
Date: Fri, 16 May 2025 16:21:26 GMT
Subject: Re: [PATCH] sequencer: make it clearer that commit descriptions are just comments
Message-ID: <xmqqikm0wmpl.fsf@gitster.g>
In-Reply-To: <ABFDED43-3AC7-455E-9736-A8D9AC0F3A40@gmail.com>

Ben Knoble <ben.knoble@gmail.com> writes:

>> Le 15 mai 2025 à 11:56, Junio C Hamano <gitster@pobox.com> a écrit :
>> 
>> Phillip Wood <phillip.wood123@gmail.com> writes:
>> 
>>>> -        grep -v -e \# -e ^$ work >patches &&
>>>> +        sed -e s/#.*// work | grep -v ^$ >patches &&
>>> 
>>> I think we could just use 'sed -n "!/^#/p work >patches &&" here
>> 
>> Or even "sed -e '/^#/d' -e '/^$/d'" ?
>
> I’m probably missing something obvious, but why step away from "grep -v -e ^\# -e ^$"? A one character change from the original ;) If we must go with Sed, I’d prefer Junio’s construct (combining, with obvious semantics via "d") over the sed|grep pipeline. 

Mine was a spinal reflex against piping sed and grep; I do not see a
reason why "grep -v" with two patterns like you gave should not
work---that is a good way to remove the pipe, too.

Thanks.