git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] CodingGuidelines: update the required Perl version

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 5, 2026, 17:42 UTC
Message-ID
<xmqqik2bw4y6.fsf@gitster.g>
In-Reply-To
<auuxjhaauAQ7Vtjs@fruit.crustytoothpaste.net>
"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 30 quoted lines
> On 2026-11-04 at 19:56:57, Junio C Hamano wrote:
>> Tuomas Ahola <taahol@utu.fi> writes:
>> 
>> > Junio C Hamano <gitster@pobox.com> wrote:
>> >
>> >> Tuomas Ahola <taahol@utu.fi> writes:
>> >> 
>> >> > - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
>> >> > + - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
>> >> 
>> >> Is this in line with what 702d8c1f3b did?  Shouldn't we say
>> >> 
>> >> > + - We try to support Perl 5.26.0 and later ("require v5.26").
>> >> 
>> >> "require v5.26" instead?
>> ...
>> It looks to me that the "parenthetical" you called was designed to
>> be useful by telling you what to have near the top of your Perl
>> source files.  Replacing it with "require v5.26" is exactly in line
>> with that, I would think.
>
> As mentioned above, you want `require`, not `use`, with Perl versions.
> The latter enables the relevant features, which include Unicode strings
> as of 5.12, and that will change the behaviour of our code in ways we're
> probably not expecting.  That didn't happen in 5.8.1 because features
> didn't exist, so the `use` for that version was okay.
>
> You effectively always want `require v5.26` or something equivalent such
> as `require 5.026` in our codebase.  The former is nicer to read,
> though.

Thanks. Let's see the final version that can immediately be marked as ready for 'next' then.

Previous: brian m. carlsonNext: Junio C Hamano
Message 6 of 10 in “CodingGuidelines: update the required Perl version”
  1. CodingGuidelines: update the required Perl versionTuomas Ahola, Nov 1, 2026
  2. Junio C HamanoNov 2, 2026
  3. Tuomas AholaNov 4, 2026
  4. Junio C HamanoNov 4, 2026
  5. brian m. carlsonNov 4, 2026
  6. Junio C HamanoNov 5, 2026
  7. Junio C HamanoNov 2, 2026
  8. Junio C HamanoNov 4, 2026
  9. CodingGuidelines: update the required Perl versionTuomas Ahola, Nov 5, 2026
  10. Junio C HamanoNov 5, 2026

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.