threads / patch / 66740

patchCodingGuidelines: update the required Perl version

Subject: [PATCH] CodingGuidelines: update the required Perl version

## tl;dr

10 messages between Nov 1, 2026 and Nov 5, 2026. Diffs are folded; open one to read it.

replies: 9people: 3as markdown or json

Tuomas Ahola· Nov 1, 2026, 18:58 UTC · lore

702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version requirement. Update CodingGuidelines accordingly.

Signed-off-by: Tuomas Ahola <taahol@utu.fi>
---
 Documentation/CodingGuidelines | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/CodingGuidelines +1 −1
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index c06f5d3071..9b17ab34db 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -703,7 +703,7 @@ For Perl programs:
 
  - Most of the C guidelines above apply.
 
- - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
+ - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
 
  - use strict and use warnings are strongly preferred.
 

base-commit: a018953688f1b10bddf91bff8747068f5f4746a4
-- 
ta/coding-guidelines-perl-version
Junio C Hamano· Nov 2, 2026, 04:08 UTC · re: Tuomas Ahola · lore

Re: [PATCH] CodingGuidelines: update the required Perl version

Tuomas Ahola <taahol@utu.fi> writes:
Show 18 quoted lines
> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version
> requirement.  Update CodingGuidelines accordingly.
>
> Signed-off-by: Tuomas Ahola <taahol@utu.fi>
> ---
>  Documentation/CodingGuidelines | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index c06f5d3071..9b17ab34db 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -703,7 +703,7 @@ For Perl programs:
>  
>   - Most of the C guidelines above apply.
>  
> - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
> + - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
Is this in line with what 702d8c1f3b did?  Shouldn't we say
> + - We try to support Perl 5.26.0 and later ("require v5.26").
"require v5.26" instead?
commit 702d8c1f3b5377a64670b0f22add157b0bfc33dd
Author: brian m. carlson <sandals@crustytoothpaste.net>
Date:   Wed Oct 23 00:45:59 2024 +0000
    Require Perl 5.26.0
...    
    This change was made with the following one-liner, which intentionally
    excludes modifying the vendored modules we include to avoid conflicts:
    
        git grep -l 'use 5.008001' |
	grep -v 'LoadCPAN/' |
	xargs perl -pi -e 's/use 5.008001/require v5.26/'
    
    Use require instead of use to avoid changing the behavior as the latter
    enables features and the former does not.
    
    Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
    Signed-off-by: Taylor Blau <me@ttaylorr.com>
Show changes to contrib/diff-highlight/DiffHighlight.pm +1 −1
diff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm
index 636add6968..3d061bc0b7 100644
--- a/contrib/diff-highlight/DiffHighlight.pm
+++ b/contrib/diff-highlight/DiffHighlight.pm
@@ -1,6 +1,6 @@
 package DiffHighlight;
 
-use 5.008001;
+require v5.26;
 use warnings FATAL => 'all';
 use strict;
Tuomas Ahola· Nov 4, 2026, 19:34 UTC · re: Junio C Hamano · lore

Re: [PATCH] CodingGuidelines: update the required Perl version

Junio C Hamano <gitster@pobox.com> wrote:
Show 27 quoted lines
> Tuomas Ahola <taahol@utu.fi> writes:
> 
> > 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version
> > requirement.  Update CodingGuidelines accordingly.
> >
> > Signed-off-by: Tuomas Ahola <taahol@utu.fi>
> > ---
> >  Documentation/CodingGuidelines | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> > index c06f5d3071..9b17ab34db 100644
> > --- a/Documentation/CodingGuidelines
> > +++ b/Documentation/CodingGuidelines
> > @@ -703,7 +703,7 @@ For Perl programs:
> >  
> >   - Most of the C guidelines above apply.
> >  
> > - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
> > + - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
> 
> Is this in line with what 702d8c1f3b did?  Shouldn't we say
> 
> > + - We try to support Perl 5.26.0 and later ("require v5.26").
> 
> "require v5.26" instead?
> 

Frankly, I don't make head nor tail of such Perl minutiae. I would find that parenthetical much more useful if it told exactly when we are supposed to use such incantations.

For example:
 - All new code should carry the line "require v5.26".
or
 - Please consider adding "require v5.26" whenever appropriate.

I'm not really sure how to proceed with this. One option is of course to adopt your suggestion and call it a day.

Junio C Hamano· Nov 4, 2026, 19:56 UTC · re: Tuomas Ahola · lore

Re: [PATCH] CodingGuidelines: update the required Perl version

Tuomas Ahola <taahol@utu.fi> writes:
Show 33 quoted lines
> Junio C Hamano <gitster@pobox.com> wrote:
>
>> Tuomas Ahola <taahol@utu.fi> writes:
>> 
>> > 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version
>> > requirement.  Update CodingGuidelines accordingly.
>> >
>> > Signed-off-by: Tuomas Ahola <taahol@utu.fi>
>> > ---
>> >  Documentation/CodingGuidelines | 2 +-
>> >  1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
>> > index c06f5d3071..9b17ab34db 100644
>> > --- a/Documentation/CodingGuidelines
>> > +++ b/Documentation/CodingGuidelines
>> > @@ -703,7 +703,7 @@ For Perl programs:
>> >  
>> >   - Most of the C guidelines above apply.
>> >  
>> > - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
>> > + - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
>> 
>> Is this in line with what 702d8c1f3b did?  Shouldn't we say
>> 
>> > + - We try to support Perl 5.26.0 and later ("require v5.26").
>> 
>> "require v5.26" instead?
>> 
>
> Frankly, I don't make head nor tail of such Perl minutiae.  I would find that
> parenthetical much more useful if it told exactly when we are supposed to use
> such incantations.

I do not claim to be intimately familiar, but you can consult the commit you cited as the reason why you decided to make this update.

    $ git show 702d8c1f3b
    commit 702d8c1f3b5377a64670b0f22add157b0bfc33dd
    Author: brian m. carlson <sandals@crustytoothpaste.net>
    Date:   Wed Oct 23 00:45:59 2024 +0000
        Require Perl 5.26.0
        Our platform support policy states that we require "versions of
        ...
        Use require instead of use to avoid changing the behavior as the latter
        enables features and the former does not.
        Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
        Signed-off-by: Taylor Blau <me@ttaylorr.com>
    ...
    diff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm
    index 636add6968..3d061bc0b7 100644
    --- a/contrib/diff-highlight/DiffHighlight.pm
    +++ b/contrib/diff-highlight/DiffHighlight.pm
    @@ -1,6 +1,6 @@
     package DiffHighlight;
    -use 5.008001;
    +require v5.26;
     use warnings FATAL => 'all';
     use strict;

It looks to me that the "parenthetical" you called was designed to be useful by telling you what to have near the top of your Perl source files. Replacing it with "require v5.26" is exactly in line with that, I would think.

brian m. carlson· Nov 4, 2026, 22:28 UTC · re: Junio C Hamano · lore

Re: [PATCH] CodingGuidelines: update the required Perl version

On 2026-11-04 at 19:56:57, Junio C Hamano wrote:
Show 55 quoted lines
> Tuomas Ahola <taahol@utu.fi> writes:
> 
> > Junio C Hamano <gitster@pobox.com> wrote:
> >
> >> Tuomas Ahola <taahol@utu.fi> writes:
> >> 
> >> > - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
> >> > + - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
> >> 
> >> Is this in line with what 702d8c1f3b did?  Shouldn't we say
> >> 
> >> > + - We try to support Perl 5.26.0 and later ("require v5.26").
> >> 
> >> "require v5.26" instead?
> >> 
> >
> > Frankly, I don't make head nor tail of such Perl minutiae.  I would find that
> > parenthetical much more useful if it told exactly when we are supposed to use
> > such incantations.
> 
> I do not claim to be intimately familiar, but you can consult the
> commit you cited as the reason why you decided to make this update.
> 
>     $ git show 702d8c1f3b
>     commit 702d8c1f3b5377a64670b0f22add157b0bfc33dd
>     Author: brian m. carlson <sandals@crustytoothpaste.net>
>     Date:   Wed Oct 23 00:45:59 2024 +0000
> 
>         Require Perl 5.26.0
> 
>         Our platform support policy states that we require "versions of
>         ...
>         Use require instead of use to avoid changing the behavior as the latter
>         enables features and the former does not.
> 
>         Signed-off-by: brian m. carlson <sandals@crustytoothpaste.net>
>         Signed-off-by: Taylor Blau <me@ttaylorr.com>
> 
>     ...
>     diff --git a/contrib/diff-highlight/DiffHighlight.pm b/contrib/diff-highlight/DiffHighlight.pm
>     index 636add6968..3d061bc0b7 100644
>     --- a/contrib/diff-highlight/DiffHighlight.pm
>     +++ b/contrib/diff-highlight/DiffHighlight.pm
>     @@ -1,6 +1,6 @@
>      package DiffHighlight;
> 
>     -use 5.008001;
>     +require v5.26;
>      use warnings FATAL => 'all';
>      use strict;
> 
> It looks to me that the "parenthetical" you called was designed to
> be useful by telling you what to have near the top of your Perl
> source files.  Replacing it with "require v5.26" is exactly in line
> with that, I would think.

As mentioned above, you want `require`, not `use`, with Perl versions. The latter enables the relevant features, which include Unicode strings as of 5.12, and that will change the behaviour of our code in ways we're probably not expecting. That didn't happen in 5.8.1 because features didn't exist, so the `use` for that version was okay.

You effectively always want `require v5.26` or something equivalent such as `require 5.026` in our codebase. The former is nicer to read, though.

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA
Speaking for myself only
Junio C Hamano· Nov 5, 2026, 17:42 UTC · re: brian m. carlson · lore

Re: [PATCH] CodingGuidelines: update the required Perl version

"brian m. carlson" <sandals@crustytoothpaste.net> writes:
Show 30 quoted lines
> On 2026-11-04 at 19:56:57, Junio C Hamano wrote:
>> Tuomas Ahola <taahol@utu.fi> writes:
>> 
>> > Junio C Hamano <gitster@pobox.com> wrote:
>> >
>> >> Tuomas Ahola <taahol@utu.fi> writes:
>> >> 
>> >> > - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
>> >> > + - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
>> >> 
>> >> Is this in line with what 702d8c1f3b did?  Shouldn't we say
>> >> 
>> >> > + - We try to support Perl 5.26.0 and later ("require v5.26").
>> >> 
>> >> "require v5.26" instead?
>> ...
>> It looks to me that the "parenthetical" you called was designed to
>> be useful by telling you what to have near the top of your Perl
>> source files.  Replacing it with "require v5.26" is exactly in line
>> with that, I would think.
>
> As mentioned above, you want `require`, not `use`, with Perl versions.
> The latter enables the relevant features, which include Unicode strings
> as of 5.12, and that will change the behaviour of our code in ways we're
> probably not expecting.  That didn't happen in 5.8.1 because features
> didn't exist, so the `use` for that version was okay.
>
> You effectively always want `require v5.26` or something equivalent such
> as `require 5.026` in our codebase.  The former is nicer to read,
> though.

Thanks. Let's see the final version that can immediately be marked as ready for 'next' then.

Junio C Hamano· Nov 2, 2026, 06:41 UTC · re: Tuomas Ahola · lore

Re: [PATCH] CodingGuidelines: update the required Perl version

Tuomas Ahola <taahol@utu.fi> writes:
Show 7 quoted lines
> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version
> requirement.  Update CodingGuidelines accordingly.
>
> Signed-off-by: Tuomas Ahola <taahol@utu.fi>
> ---
>  Documentation/CodingGuidelines | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
Makes sense.  Thanks.
Show 16 quoted lines
>
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index c06f5d3071..9b17ab34db 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -703,7 +703,7 @@ For Perl programs:
>  
>   - Most of the C guidelines above apply.
>  
> - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
> + - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
>  
>   - use strict and use warnings are strongly preferred.
>  
>
> base-commit: a018953688f1b10bddf91bff8747068f5f4746a4
Junio C Hamano· Nov 4, 2026, 18:59 UTC · re: Junio C Hamano · lore

Re: [PATCH] CodingGuidelines: update the required Perl version

Junio C Hamano <gitster@pobox.com> writes:
Show 11 quoted lines
> Tuomas Ahola <taahol@utu.fi> writes:
>
>> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version
>> requirement.  Update CodingGuidelines accordingly.
>>
>> Signed-off-by: Tuomas Ahola <taahol@utu.fi>
>> ---
>>  Documentation/CodingGuidelines | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> Makes sense.  Thanks.
Oh, no, not so fast.
I'll mark the topic as "Waiting for response".
https://lore.kernel.org/git/xmqqjymvooyn.fsf@gitster.g/
Tuomas Ahola· Nov 5, 2026, 18:39 UTC · re: Tuomas Ahola · lore

[PATCH v2] CodingGuidelines: update the required Perl version

702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version requirement and migrated the codebase to use "require vx.y.z" in lieu of "use x.y_z". Update CodingGuidelines accordingly.

Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
Signed-off-by: Tuomas Ahola <taahol@utu.fi>
---
Intervall-diff mot v1:
1:  d18ca7697d ! 1:  70e2656643 CodingGuidelines: update the required Perl version
    @@ Commit message
         CodingGuidelines: update the required Perl version
     
         702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version
    -    requirement.  Update CodingGuidelines accordingly.
    +    requirement and migrated the codebase to use "require vx.y.z" in lieu
    +    of "use x.y_z".  Update CodingGuidelines accordingly.
     
    +    Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
         Signed-off-by: Tuomas Ahola <taahol@utu.fi>
     
      ## Documentation/CodingGuidelines ##
    @@ Documentation/CodingGuidelines: For Perl programs:
       - Most of the C guidelines above apply.
      
     - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
    -+ - We try to support Perl 5.26.0 and later ("use Perl 5.026000").
    ++ - We try to support Perl 5.26.0 and later ("require v5.26").
      
       - use strict and use warnings are strongly preferred.
      
 Documentation/CodingGuidelines | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Show changes to Documentation/CodingGuidelines +1 −1
diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
index c06f5d3071..bc0470c154 100644
--- a/Documentation/CodingGuidelines
+++ b/Documentation/CodingGuidelines
@@ -703,7 +703,7 @@ For Perl programs:
 
  - Most of the C guidelines above apply.
 
- - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
+ - We try to support Perl 5.26.0 and later ("require v5.26").
 
  - use strict and use warnings are strongly preferred.
 

base-commit: a018953688f1b10bddf91bff8747068f5f4746a4
-- 
ta/cg-require-perl-5.26.0
Junio C Hamano· Nov 5, 2026, 18:45 UTC · re: Tuomas Ahola · lore

Re: [PATCH v2] CodingGuidelines: update the required Perl version

Tuomas Ahola <taahol@utu.fi> writes:
Show 17 quoted lines
> 702d8c1f3b (Require Perl 5.26.0, 2024-10-23) bumped Git's Perl version
> requirement and migrated the codebase to use "require vx.y.z" in lieu
> of "use x.y_z".  Update CodingGuidelines accordingly.
>
> Helped-by: brian m. carlson <sandals@crustytoothpaste.net>
> Signed-off-by: Tuomas Ahola <taahol@utu.fi>
> ---
> diff --git a/Documentation/CodingGuidelines b/Documentation/CodingGuidelines
> index c06f5d3071..bc0470c154 100644
> --- a/Documentation/CodingGuidelines
> +++ b/Documentation/CodingGuidelines
> @@ -703,7 +703,7 @@ For Perl programs:
>  
>   - Most of the C guidelines above apply.
>  
> - - We try to support Perl 5.8.1 and later ("use Perl 5.008001").
> + - We try to support Perl 5.26.0 and later ("require v5.26").
Looks good.  Will queue.
Thanks.

← back to recent threads