From: Junio C Hamano Date: Thu, 05 Nov 2026 17:42:09 GMT Subject: Re: [PATCH] CodingGuidelines: update the required Perl version Message-ID: In-Reply-To: "brian m. carlson" writes: > On 2026-11-04 at 19:56:57, Junio C Hamano wrote: >> Tuomas Ahola writes: >> >> > Junio C Hamano wrote: >> > >> >> Tuomas Ahola writes: >> >> >> >> > - - We try to support Perl 5.8.1 and later ("use Perl 5.008001"). >> >> > + - We try to support Perl 5.26.0 and later ("use Perl 5.026000"). >> >> >> >> Is this in line with what 702d8c1f3b did? Shouldn't we say >> >> >> >> > + - We try to support Perl 5.26.0 and later ("require v5.26"). >> >> >> >> "require v5.26" instead? >> ... >> It looks to me that the "parenthetical" you called was designed to >> be useful by telling you what to have near the top of your Perl >> source files. Replacing it with "require v5.26" is exactly in line >> with that, I would think. > > As mentioned above, you want `require`, not `use`, with Perl versions. > The latter enables the relevant features, which include Unicode strings > as of 5.12, and that will change the behaviour of our code in ways we're > probably not expecting. That didn't happen in 5.8.1 because features > didn't exist, so the `use` for that version was okay. > > You effectively always want `require v5.26` or something equivalent such > as `require 5.026` in our codebase. The former is nicer to read, > though. Thanks. Let's see the final version that can immediately be marked as ready for 'next' then.