Re: [PATCH v1 2/2] git-p4: fix Git LFS pointer parsing

From: Junio C Hamano <gitster@pobox.com>
Date: Apr 19, 2016, 21:04 UTC
Message-ID: <xmqqh9exz4xq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <A6FD8E93-63E8-49EE-838D-2AF3FD3910D4@gmail.com>

Lars Schneider <larsxschneider@gmail.com> writes:

Show 12 quoted lines

>> On 19 Apr 2016, at 22:30, Junio C Hamano <gitster@pobox.com> wrote:
>> 
>> larsxschneider@gmail.com writes:
>> 
>>> From: Lars Schneider <larsxschneider@gmail.com>
>>> 
>>> Git LFS 1.2.0 removed a line from the output of the 'git lfs pointer'
>>> command [1] which broke the parsing of this output. Adjust the parser
>>> to the new output and add minimum Git LFS version to the docs.
>> 
>> Hmph, adjust to operate with both, or drop the support for the old
>> one?

> I dropped the support for the older version to keep the code as
> simple as possible (plus it would be cumbersome to test with an
> outdated Git LFS version). Since it is probably a niche feature I
> thought that might be acceptable.

It is bad enough that clients need to be adjusted at all in the first place, but I would have found it very troubling if the problematic change to LFS thing were made in such a way that it makes backward compatible adjustment on the client code impossible.

But it seems that you could read their output and strip a line that begins with a known substring to make it compatible with both?

"git P4" itself may be niche and using it with the LFS thing may even be more so, but in Git land, traditionally we take the backward compatibility seriously. If it is not too much work, I'd prefer to see this done the right way.

Thanks.