Re: [PATCH] t9824: fix broken &&-chain in a subshell

From: SZEDER Gábor <szeder@ira.uka.de>
Date: Apr 24, 2016, 16:37 UTC
Message-ID: <20160424183729.Horde.yxK_t3vqDHiCc6kvoXJqwst@webmail.informatik.kit.edu>
In-Reply-To: <78046710-31FD-43D8-820E-95D56564C3F5@gmail.com>

Quoting Lars Schneider <larsxschneider@gmail.com>:

Show 24 quoted lines

> On 24 Apr 2016, at 13:50, SZEDER Gábor <szeder@ira.uka.de> wrote:
>
>> Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
>> ---
>>
>> As far as I can tell after eyeballing the test script, this was the
>> only case where the &&-chain was broken.
>>
>> t/t9824-git-p4-git-lfs.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/t/t9824-git-p4-git-lfs.sh b/t/t9824-git-p4-git-lfs.sh
>> index 0b664a377c45..64f8d18216d4 100755
>> --- a/t/t9824-git-p4-git-lfs.sh
>> +++ b/t/t9824-git-p4-git-lfs.sh
>> @@ -265,7 +265,7 @@ test_expect_success 'Add big files to repo and  
>> store files in LFS based on compr
>> 		# We only import HEAD here ("@all" is missing!)
>> 		git p4 clone --destination="$git" //depot &&
>>
>> -		test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ"
>> +		test_file_in_lfs file6.bin 13 "content 6 bin 39 bytes XXXXXYYYYYZZZZZ" &&
> Thanks! I believe I remember some script/flag to detect broken &&-chains.
> Do I imagine that or can anyone point me to it?

It was introduced in bb79af9d0970 (t/test-lib: introduce --chain-lint option, 2015-03-20) and is enabled by default. Unfortunately, it can't "see" inside subshells, that's why it couldn't detect this case.

Show 6 quoted lines

>> 		test_file_count_in_dir ".git/lfs/objects" 1 &&
>>
>> 		cat >expect <<-\EOF &&
>> --
>> 2.8.1.99.g5d5236f
>>