Re: [PATCH v1 2/2] git-p4: fix Git LFS pointer parsing

From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Apr 20, 2016, 08:32 UTC
Message-ID: <CAHGBnuOuFYvf=CSyCLbhn7pyq4jsqH+p+xV9rxAtU1y3r+qjzw@mail.gmail.com>
In-Reply-To: <xmqqh9exz4xq.fsf@gitster.mtv.corp.google.com>

On Tue, Apr 19, 2016 at 11:04 PM, Junio C Hamano <gitster@pobox.com> wrote:

Show 9 quoted lines

>> I dropped the support for the older version to keep the code as
>> simple as possible (plus it would be cumbersome to test with an
>> outdated Git LFS version). Since it is probably a niche feature I
>> thought that might be acceptable.
>
> It is bad enough that clients need to be adjusted at all in the
> first place, but I would have found it very troubling if the
> problematic change to LFS thing were made in such a way that it
> makes backward compatible adjustment on the client code impossible.

If clients rely on output targeted at human consumption it's not surprising that these clients need to be adjusted from time to time. What's troubling is not the change to git-lfs, but the very un-generic way git-p4 is implemented.

-- 
Sebastian Schuberth