git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 1/1] Don't free remote->name after fetch

From
Junio C Hamano <gitster@pobox.com>
Date
Jun 14, 2016, 17:52 UTC
Message-ID
<xmqqh9cvaca3.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<CALnYDJNS9QAtu37a76Q6N3C=GRbfgU8Xq3g7F1q7vX+b=rwOOA@mail.gmail.com>
Keith McGuigan <kmcguigan@twopensource.com> writes:
> As an alternative, I could xstrdup each instance where remote->name is appended,
> which would make the string_list a homogenous dup'd list, which we
> could then free.

Yeah, I think that is the right way to fix it, even though I agree with you that a small leak you introduced is probably better than unwanted freeing we currently have.

Previous: Jeff King
Message 5 of 5 in “Don't free remote->name after fetch”
  1. 1/1 Don't free remote->name after fetchkmcguigan@twopensource.com, Jun 13, 2016
  2. Junio C HamanoJun 13, 2016
  3. Keith McGuiganJun 14, 2016
  4. Jeff KingJun 14, 2016
  5. Junio C HamanoJun 14, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.