From: Junio C Hamano Date: Tue, 14 Jun 2016 17:52:20 GMT Subject: Re: [PATCH 1/1] Don't free remote->name after fetch Message-ID: In-Reply-To: Keith McGuigan writes: > As an alternative, I could xstrdup each instance where remote->name is appended, > which would make the string_list a homogenous dup'd list, which we > could then free. Yeah, I think that is the right way to fix it, even though I agree with you that a small leak you introduced is probably better than unwanted freeing we currently have.