Re: What's cooking in git.git (Jul 2016, #05; Wed, 13)

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 13, 2016, 17:46 UTC
Message-ID: <xmqqh9bt1ldy.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CACsJy8CVJr6-9CnyrOU4UoPPGu6Ovn_=-2YKeqC8Lp_rVnh5fg@mail.gmail.com>

Duy Nguyen <pclouds@gmail.com> writes:

Show 7 quoted lines

> On the subject of truncation, there is something else I should note.
> The field sd_size in struct stat_data is 32 bits, so large files will
> overflow it too, regardless of platforms. I did not do anything
> because I checked and double checked and was pretty sure we did not
> use it for anything meaningful (as a file size). To us, it's just
> another random number, like st_ino, that we check to detect if a file
> has changed.

Yes, the comparison to flip DATA_CHANGED bit near the end of match_stat_data() has a cast for that exact reason. It might deserve a comment there.