git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: What's cooking in git.git (Jul 2016, #05; Wed, 13)

From
Jeff King <peff@peff.net>
Date
Jul 13, 2016, 22:42 UTC
Message-ID
<20160713224256.GA8980@sigill.intra.peff.net>
In-Reply-To
<xmqqinw9yxdu.fsf@gitster.mtv.corp.google.com>
On Wed, Jul 13, 2016 at 03:41:01PM -0700, Junio C Hamano wrote:
Show 24 quoted lines
> Stefan Beller <sbeller@google.com> writes:
> 
> >>> I think Shawns proposal to have a receive.maxCommandBytes is a
> >>> good way for an overall upper bound, but how does it stop us from
> >>> going forward with this series?
> >>
> >> If we were to do maxcommandbytes, then max_options would become
> >> irrelevant, no?
> >
> > Maybe?
> >
> > I do not know what kind of safety measures we want in place here, and
> > if we want to go for overlapping things?
> >
> > Currently there are none at all in your upstream code, although you cannot
> > push arbitrary large things to either Shawns or Peffs $Dayjob servers, so
> > I wonder if we want to either agree on one format or on many overlapping
> > things, as some different hosts may perceive different things as DoS threats,
> > so they can fine tune as they want?
> 
> I think those extra knobs can come later.  If we are not going to
> limit with max_options in the end, however, wouldn't it be more
> natural for the initial iteration without any configuration not to
> have hard-coded max_options at all?

Yeah, I am OK with adding restrictive knobs later as a separate topic. As Stefan notes, upstream does not have the other knobs anyway, and IIRC the push-options feature is not even enabled by default.

-Peff
Previous: Junio C HamanoNext: Duy Nguyen
Message 7 of 21 in “What's cooking in git.git (Jul 2016, #05; Wed, 13)”
  1. Junio C HamanoJul 13, 2016
  2. Stefan BellerJul 13, 2016
  3. Junio C HamanoJul 13, 2016
  4. Stefan BellerJul 13, 2016
  5. Junio C HamanoJul 13, 2016
  6. Junio C HamanoJul 13, 2016
  7. Jeff KingJul 13, 2016
  8. Duy NguyenJul 13, 2016
  9. Junio C HamanoJul 13, 2016
  10. Johannes SchindelinJul 14, 2016
  11. Johannes SchindelinJul 14, 2016
  12. Junio C HamanoJul 14, 2016
  13. Johannes SchindelinJul 14, 2016
  14. Junio C HamanoJul 14, 2016
  15. Lars SchneiderJul 16, 2016
  16. Eric WongJul 16, 2016
  17. Lars SchneiderJul 16, 2016
  18. list: avoid incompatibility with *BSD sys/queue.hEric Wong, Jul 17, 2016
  19. Eric SunshineJul 17, 2016
  20. Eric WongJul 17, 2016
  21. Lars SchneiderJul 18, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.