Re: What's cooking in git.git (Jul 2016, #05; Wed, 13)

From: Stefan Beller <sbeller@google.com>
Date: Jul 13, 2016, 17:27 UTC
Message-ID: <CAGZ79kY7pWUG7Q0fDhieHCBCpR5RCongzHth6DWOJaEkcGqMEA@mail.gmail.com>
In-Reply-To: <xmqqy4551nph.fsf@gitster.mtv.corp.google.com>

> * sb/push-options (2016-07-12) 5 commits
>  - add a test for push options
>  - push: accept push options
>  - SQUASH???

Squash? I do not find a squashable commit in what you pushed, do you intend to squash the first 2 patches instead?

Show 8 quoted lines

>  - receive-pack: implement advertising and receiving push options
>  - push options: {pre,post}-receive hook learns about push options
>
>  "git push" learned to accept and pass extra options to the
>  receiving end so that hooks can read and react to them.
>
>  Discussion continues, expecting a further reroll.
>  ($gmane/299156)

Yeah there were some late comments, so I did not reroll right away. I think Shawns proposal to have a receive.maxCommandBytes is a good way for an overall upper bound, but how does it stop us from going forward with this series? It seems like a good series to implement on top of this?

(We also have no code for limiting the number of refs pushed, so I do not quite understand why this DoS paranoia comes up with this series all of a sudden.)