Re: git submodules implementation question

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 31, 2016, 18:44 UTC
Message-ID: <xmqqh9a022xt.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAN5XQfvK7M5eSkMfz5iRTnE_va9VGjONAPO5hmF+iQg-i3XEpQ@mail.gmail.com>

Uma Srinivasan <usrinivasan@twitter.com> writes:

Show 11 quoted lines

> diff --git a/submodule.c b/submodule.c
> index 5a62aa2..23443a7 100644
> --- a/submodule.c
> +++ b/submodule.c
> @@ -960,6 +960,9 @@ unsigned is_submodule_modified(const char *path,
> int ignore_untracked)
>                 return 0;
>
>         }
> +       /* stuff submodule git dir into env var */
> +       set_git_dir(git_dir);

We want to affect only the process we are going to spawn to work inside the submodule, not ourselves, which is what this call does; this does not sound like a good idea.