Re: git submodules implementation question

From: Stefan Beller <sbeller@google.com>
Date: Sep 1, 2016, 18:37 UTC
Message-ID: <CAGZ79kZnhNVBy6Oqt=x8m0jZj_tGNkMPPBBr+aL6DToOYtv9vQ@mail.gmail.com>
In-Reply-To: <xmqqmvjrwjwm.fsf@gitster.mtv.corp.google.com>

> The final version needs to be accompanied with tests to show the
> effect of this change for callers.  A test would set up a top-level
> and submodule, deliberately break submodule/.git/ repository and
> show what breaks and how without this change.

Tests are really good at providing this context as well, or to communicate the actual underlying problem, which is not quite clear to me. That is why I refrained from jumping into the discussion as I think the first few emails were dropped from the mailing list and I am missing context.

>
> So it is a bit more involved than just a single liner patch with one
> paragraph log message.  I may be able to find or make some time
> after I tag the 2.10 final this weekend to do so myself.

Thanks, Stefan