git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] clean up confusing suggestion for commit references

From
Junio C Hamano <gitster@pobox.com>
Date
Oct 10, 2016, 18:24 UTC
Message-ID
<xmqqh98kf4fy.fsf@gitster.mtv.corp.google.com>
In-Reply-To
<20161007143200.qw77pdsymbdmjhbw@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> On Fri, Oct 07, 2016 at 11:56:38AM +0200, Heiko Voigt wrote:
>
>> The description for referencing commits looks as if it is contradicting
>> the example, since it is itself enclosed in double quotes. Lets use
>> single quotes around the description and include the double quotes in
>> the description so it matches the example.
>> ---
>> Sorry for opening this up again but I just looked up the format and was
>> like: "Umm, which one is now the correct one..."
>> 
>> For this makes more sense. What do others think?
>
> Looking over the threads, I wasn't sure there was consensus[1,2]. So it would
> be equally correct to drop the quotes from the example.
>
> I dunno. I am in favor of no-quotes, myself, so maybe I am just
> manufacturing dissent in my mind. :)

I no longer have preference either way myself, even though I was in favor of no-quotes simply because I had an alias to produce that format and was used to it.

Previous: Jeff KingNext: Jeff King
Message 3 of 7 in “clean up confusing suggestion for commit references”
  1. clean up confusing suggestion for commit referencesHeiko Voigt, Oct 7, 2016
  2. Jeff KingOct 7, 2016
  3. Junio C HamanoOct 10, 2016
  4. Jeff KingOct 10, 2016
  5. Junio C HamanoOct 10, 2016
  6. Heiko VoigtOct 11, 2016
  7. Junio C HamanoOct 10, 2016

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.