Re: [PATCH] clean up confusing suggestion for commit references
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Oct 10, 2016, 18:24 UTC
- Message-ID
- <xmqqh98kf4fy.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <20161007143200.qw77pdsymbdmjhbw@sigill.intra.peff.net>
Jeff King <peff@peff.net> writes:
Show 17 quoted lines
> On Fri, Oct 07, 2016 at 11:56:38AM +0200, Heiko Voigt wrote: > >> The description for referencing commits looks as if it is contradicting >> the example, since it is itself enclosed in double quotes. Lets use >> single quotes around the description and include the double quotes in >> the description so it matches the example. >> --- >> Sorry for opening this up again but I just looked up the format and was >> like: "Umm, which one is now the correct one..." >> >> For this makes more sense. What do others think? > > Looking over the threads, I wasn't sure there was consensus[1,2]. So it would > be equally correct to drop the quotes from the example. > > I dunno. I am in favor of no-quotes, myself, so maybe I am just > manufacturing dissent in my mind. :)
I no longer have preference either way myself, even though I was in favor of no-quotes simply because I had an alias to produce that format and was used to it.