Re: [PATCH] clean up confusing suggestion for commit references
- From
Heiko Voigt <hvoigt@hvoigt.net>
- Date
- Oct 11, 2016, 16:47 UTC
- Message-ID
- <20161011164743.GA78613@book.hvoigt.net>
- In-Reply-To
- <xmqqoa2sdnjt.fsf@gitster.mtv.corp.google.com>
On Mon, Oct 10, 2016 at 12:14:14PM -0700, Junio C Hamano wrote:
Show 19 quoted lines
> Jeff King <peff@peff.net> writes: > > > On Mon, Oct 10, 2016 at 11:24:01AM -0700, Junio C Hamano wrote: > > > >> I no longer have preference either way myself, even though I was in > >> favor of no-quotes simply because I had an alias to produce that > >> format and was used to it. > > > > I'll admit that I don't care _that_ much and am happy to leave it up to > > individual authors, as long as nobody quotes SubmittingPatches at me as > > some kind of gospel when I use the no-quotes form. > > ;-). > > I just do not want to hear "gitk (or was it git-gui) produces quoted > form, why are you recommending no-quoted form in SubmittingPatches?" > > I'd say "use common sense; sometimes it is less confusing to read > without quotes and it is perfectly OK to do so if that is the case".
I do not care about which format it should be either. I just wanted to be clear about whatever should be used. Since it seems we will allow both, I am also fine with leaving the description as it is ;-)
Cheers Heiko