Re: [PATCH] clean up confusing suggestion for commit references

From: Jeff King <peff@peff.net>
Date: Oct 7, 2016, 14:32 UTC
Message-ID: <20161007143200.qw77pdsymbdmjhbw@sigill.intra.peff.net>
In-Reply-To: <20161007095638.GA55445@book.hvoigt.net>

On Fri, Oct 07, 2016 at 11:56:38AM +0200, Heiko Voigt wrote:

Show 9 quoted lines

> The description for referencing commits looks as if it is contradicting
> the example, since it is itself enclosed in double quotes. Lets use
> single quotes around the description and include the double quotes in
> the description so it matches the example.
> ---
> Sorry for opening this up again but I just looked up the format and was
> like: "Umm, which one is now the correct one..."
> 
> For this makes more sense. What do others think?

Looking over the threads, I wasn't sure there was consensus[1,2]. So it would be equally correct to drop the quotes from the example.

I dunno. I am in favor of no-quotes, myself, so maybe I am just manufacturing dissent in my mind. :)

-Peff

[1] http://public-inbox.org/git/a9731f60-5c30-0bc6-f73a-f7ffb7bd4231@kdbg.org/ [2] http://public-inbox.org/git/20160829183015.2uqnfezekjfa3ott@sigill.intra.peff.net/