Re: USE_SHA1DC is broken in pu

From: Junio C Hamano <gitster@pobox.com>
Date: Mar 21, 2017, 20:16 UTC
Message-ID: <xmqqh92mo06a.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <alpine.DEB.2.20.1703212105030.3767@virtualbox>

Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:

Show 18 quoted lines

> On Fri, 17 Mar 2017, Lars Schneider wrote:
>
>> > On 17 Mar 2017, at 11:18, Lars Schneider <larsxschneider@gmail.com>
>> > wrote:
>> > 
>> > Would it make sense/have value to add a job to our TravisCI build [1]
>> > that compiles Git in a few variations with some high profile switches
>> > such as USE_SHA1DC? Running all the tests for these variations would
>> > probably take to long but just compiling would be less than 2min per
>> > variation.
>> 
>> ... or just run individual tests instead of the entire test suite for
>> these variations (e.g. only t0013 for the USE_SHA1DC variation).
>
> The best solution may be to open a PR with .travis.yml patched to enable
> this flag. And then report back to he mailing list because the gentle
> people here are not that used to paying attention to Continuous Testing
> :-D

Actually, the best solution may be to do nothing ;-) With the current incarnation parked in 'pu' (or I may have already merged it to 'next'), without any explicit VARIANT_SHA1 request to $(MAKE), we default to use the DC_SHA1 variant.

Those who are paying attention to Travis would have noticed this by now, I thought ;-).