git/list[1] front-page[2] threads[3] people[4] search[5] about
 

USE_SHA1DC is broken in pu

From
Linus Torvalds <torvalds@linux-foundation.org>
Date
Mar 16, 2017, 19:22 UTC
Message-ID
<CA+55aFzJ3NFVoN6K9__nM_LWYfegxGo_YxB0OudTNBCG+qq+3Q@mail.gmail.com>

I think there's a semantic merge error and it clashes with f18f816cb158 ("hash.h: move SHA-1 implementation selection into a header file").

Suggested possible merge resolution attached.
                   Linus
 Makefile | 2 +-
 hash.h   | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/Makefile b/Makefile
index 9d1d958bd..186ce17f2 100644
--- a/Makefile
+++ b/Makefile
@@ -1388,9 +1388,9 @@ ifdef APPLE_COMMON_CRYPTO
 endif
 
 ifdef USE_SHA1DC
-	SHA1_HEADER = "sha1dc/sha1.h"
 	LIB_OBJS += sha1dc/sha1.o
 	LIB_OBJS += sha1dc/ubc_check.o
+	BASIC_CFLAGS += -DSHA1DC
 else
 ifdef BLK_SHA1
 	LIB_OBJS += block-sha1/sha1.o
diff --git a/hash.h b/hash.h
index f0d9ddd0c..b7f4f1fd8 100644
--- a/hash.h
+++ b/hash.h
@@ -7,6 +7,8 @@
 #include <CommonCrypto/CommonDigest.h>
 #elif defined(SHA1_OPENSSL)
 #include <openssl/sha.h>
+#elif defined(SHA1DC)
+#include "sha1dc/sha1.h"
 #else /* SHA1_BLK */
 #include "block-sha1/sha1.h"
 #endif
Next: Jeff King
Message 1 of 18 in “USE_SHA1DC is broken in pu”
  1. Linus TorvaldsMar 16, 2017
  2. Jeff KingMar 16, 2017
  3. Linus TorvaldsMar 16, 2017
  4. Junio C HamanoMar 16, 2017
  5. Linus TorvaldsMar 16, 2017
  6. Linus TorvaldsMar 16, 2017
  7. Junio C HamanoMar 16, 2017
  8. Lars SchneiderMar 17, 2017
  9. Lars SchneiderMar 17, 2017
  10. Johannes SchindelinMar 21, 2017
  11. Junio C HamanoMar 21, 2017
  12. Johannes SchindelinMar 22, 2017
  13. Jonathan NiederMar 22, 2017
  14. Johannes SchindelinMar 23, 2017
  15. Linus TorvaldsMar 23, 2017
  16. Jeff KingMar 23, 2017
  17. Junio C HamanoMar 23, 2017
  18. Jonathan NiederMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.