git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: USE_SHA1DC is broken in pu

From
Jonathan Nieder <jrnieder@gmail.com>
Date
Mar 22, 2017, 22:02 UTC
Message-ID
<20170322220246.GD26108@aiede.mtv.corp.google.com>
In-Reply-To
<alpine.DEB.2.20.1703221530040.3767@virtualbox>
Hi,
Johannes Schindelin wrote:
Show 7 quoted lines
> As to the default of seriously slowing down all SHA-1 computations: since
> you made that the default, at compile time, with no way to turn on the
> faster computation, this will have a major, negative impact. Are you
> really, really sure you want to do that?
>
> I thought that it was obvious that we would have at least a runtime option
> to lessen the load.

It's not obvious to me. I agree that the DC_SHA1 case can be sped up, e.g. by turning off the collision detection for sha1 calculations that are not part of fetching, receiving a push, or running fsck.

To be clear, are you saying that this is a bad compile-time default because distributors are going to leave it and end-users will end up with a bad experience? Or are you saying distributors have no good alternative to choose at compile time? Or something else?

Is there some particular downstream that this breaks?

Thanks and hope that helps, Jonathan

Previous: Johannes SchindelinNext: Johannes Schindelin
Message 13 of 18 in “USE_SHA1DC is broken in pu”
  1. Linus TorvaldsMar 16, 2017
  2. Jeff KingMar 16, 2017
  3. Linus TorvaldsMar 16, 2017
  4. Junio C HamanoMar 16, 2017
  5. Linus TorvaldsMar 16, 2017
  6. Linus TorvaldsMar 16, 2017
  7. Junio C HamanoMar 16, 2017
  8. Lars SchneiderMar 17, 2017
  9. Lars SchneiderMar 17, 2017
  10. Johannes SchindelinMar 21, 2017
  11. Junio C HamanoMar 21, 2017
  12. Johannes SchindelinMar 22, 2017
  13. Jonathan NiederMar 22, 2017
  14. Johannes SchindelinMar 23, 2017
  15. Linus TorvaldsMar 23, 2017
  16. Jeff KingMar 23, 2017
  17. Junio C HamanoMar 23, 2017
  18. Jonathan NiederMar 23, 2017

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.