Re: [PATCH] Drop some dashes from built-in invocations in scripts

From: Junio C Hamano <gitster@pobox.com>
Date: Aug 5, 2017, 23:31 UTC
Message-ID: <xmqqh8xlsiaq.fsf@gitster.mtv.corp.google.com>
In-Reply-To: <CAGw6cBtKF-Xt4z3m4gBDQvaSnurbtHURe737s8XMX78ca_RTcA@mail.gmail.com>

Michael Forney <mforney@mforney.org> writes:

Show 12 quoted lines

> On 8/5/17, Junio C Hamano <gitster@pobox.com> wrote:
>> Have you made sure that all of these scripts, before calling
>> 'git-foo' in the current code, update their PATH so that these found
>> in the bog standard place (i.e. GIT_EXEC_PATH)?
>>
>> The reason I ask is because we can rest assured these changes will
>> be a no-regression improvement if you did so.  I do not offhand
>> think of a reason why these scripts wouldn't be doing so, but it
>> never hurts to make sure.
>
> I just checked and all the scripts make some other call to a built-in
> with `git foo`, so I think it should be safe.

As long as they are the same "foo"'s, then the check you did is perfectly fine. The (unlikely I would think) case that can lead to a regression is if these script deliberately used `git-foo` to find them on $PATH, which can be different from 'git foo' that is found by 'git' in its own binary (as all of them are built-ins), and that is why I asked.

Thanks.