Re: [PATCH] Drop some dashes from built-in invocations in scripts
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Aug 7, 2017, 18:18 UTC
- Message-ID
- <xmqq60dzqm0z.fsf@gitster.mtv.corp.google.com>
- In-Reply-To
- <CAGw6cBvE-OJW0gSRCYOS5VT+Ff+eiCMdJg2A2rBi_HXFObdJRw@mail.gmail.com>
Michael Forney <mforney@mforney.org> writes:
> However, I still think the patch should be applied for > self-consistency at least (git-submodule.sh currently calls both `git > rev-parse` and `git-rev-parse`).
Oh, there is no question about the changes in the patch being good, as I already said. We want to make sure that people who copy & paste code would see fewer instances of "git-foo".
I was commenting on the justification in your proposed log message, which I realized was a bit misleading, after deciding that the patch text itself is good and I need to apply it.
Thanks for the clean-up.