Re: [PATCH] Drop some dashes from built-in invocations in scripts

From: Michael Forney <mforney@mforney.org>
Date: Aug 5, 2017, 22:54 UTC
Message-ID: <CAGw6cBtKF-Xt4z3m4gBDQvaSnurbtHURe737s8XMX78ca_RTcA@mail.gmail.com>
In-Reply-To: <xmqqlgmxskm6.fsf@gitster.mtv.corp.google.com>

On 8/5/17, Junio C Hamano <gitster@pobox.com> wrote:

Show 8 quoted lines

> Have you made sure that all of these scripts, before calling
> 'git-foo' in the current code, update their PATH so that these found
> in the bog standard place (i.e. GIT_EXEC_PATH)?
>
> The reason I ask is because we can rest assured these changes will
> be a no-regression improvement if you did so.  I do not offhand
> think of a reason why these scripts wouldn't be doing so, but it
> never hurts to make sure.

I just checked and all the scripts make some other call to a built-in with `git foo`, so I think it should be safe.