Re: [PATCH 2/2] repack -ad: prune the list of shallow commits

From: Junio C Hamano <gitster@pobox.com>
Date: Jul 17, 2018, 16:25 UTC
Message-ID: <xmqqh8kxrfrf.fsf@gitster-ct.c.googlers.com>
In-Reply-To: <20180716173636.GA18636@sigill.intra.peff.net>

Jeff King <peff@peff.net> writes:

Show 5 quoted lines

> I'm OK with having a partial fix, or one that fixes immediate pain
> without doing a big cleanup, as long as it doesn't make anything _worse_
> in a user-visible way. And that's really my question: is pruning here
> going to bite people unexpectedly (not rhetorical -- I really don't
> know)?

Yeah, that matches the general guideline I follow when reviewing a patch that claims to make existing things better. And I do not think I can explain to a third person why pruning here is a good idea and won't cause problems, after seeing these patches and the discussion from the sideline.

> Right, I think "git gc" is absolutely the place to do such cleanups. My
> only complaint was that having it as part of repack may be unexpected.