git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH 2/2] repack -ad: prune the list of shallow commits

From
Duy Nguyen <pclouds@gmail.com>
Date
Jul 17, 2018, 16:48 UTC
Message-ID
<CACsJy8Cxp6Gtt3YdWvQ0=t4vqBAqNxrGPeY4B7mtjsiLNpG5TQ@mail.gmail.com>
In-Reply-To
<CACsJy8Ce0kXTCzLf6jFq1QjY4Q4QePfk1JbgGUr-kQqQDCc7mA@mail.gmail.com>
On Tue, Jul 17, 2018 at 6:39 PM Duy Nguyen <pclouds@gmail.com> wrote:
Show 26 quoted lines
>
> On Fri, Jul 13, 2018 at 10:19 PM Johannes Schindelin via GitGitGadget
> <gitgitgadget@gmail.com> wrote:
> >
> > From: Johannes Schindelin <johannes.schindelin@gmx.de>
> >
> > While it is true that we never add unreachable commits into pack files
> > intentionally (as `git repack`'s documentation states), we must not
> > forget that a `git fetch --prune` (or even a `git fetch` when a ref was
> > force-pushed in the meantime) can make a commit unreachable that was
> > reachable before.
> >
> > Therefore it is not safe to assume that a `git repack -adlf` will keep
> > unreachable commits alone (under the assumption that they had not been
> > packed in the first place).
> >
> > This is particularly important to keep in mind when looking at the
> > `.git/shallow` file: if any commits listed in that file become
> > unreachable, it is not a problem, but if they go missing, it *is* a
> > problem. One symptom of this problem is that a deepening fetch may now
> > fail with
> >
> >         fatal: error in object: unshallow <commit-hash>
> >
>
> Could you elaborate a bit more?

Never mind. The problem is described in another patch.. sigh.. I understand you want to flip that "failure" to "success" but personally I don't think it worth it to look back in history and have "what?" moments like when I read this patch alone.

-- 
Duy
Previous: Duy NguyenNext: Johannes Schindelin
Message 18 of 47 in “repack -ad: fix after `fetch --prune` in a shallow repository”
  1. 0/2 repack -ad: fix after `fetch --prune` in a shallow repositoryJohannes Schindelin via GitGitGadget, Jul 13, 2018
  2. 1/2 repack: point out a bug handling stale shallow infoJohannes Schindelin via GitGitGadget, Jul 11, 2018
  3. 2/2 repack -ad: prune the list of shallow commitsJohannes Schindelin via GitGitGadget, Jul 11, 2018
  4. Jeff KingJul 13, 2018
  5. Johannes SchindelinJul 14, 2018
  6. Jeff KingJul 16, 2018
  7. Junio C HamanoJul 17, 2018
  8. Johannes SchindelinJul 19, 2018
  9. Junio C HamanoJul 19, 2018
  10. Junio C HamanoJul 20, 2018
  11. Jeff KingJul 20, 2018
  12. Duy NguyenJul 17, 2018
  13. Jeff KingJul 17, 2018
  14. Duy NguyenJul 18, 2018
  15. Jeff KingJul 18, 2018
  16. Duy NguyenJul 18, 2018
  17. Duy NguyenJul 17, 2018
  18. Duy NguyenJul 17, 2018
  19. Johannes SchindelinJul 19, 2018
  20. 0/2 repack -ad: fix after `fetch --prune` in a shallow repositoryJohannes Schindelin via GitGitGadget, Jul 17, 2018
  21. 1/2 repack: point out a bug handling stale shallow infoJohannes Schindelin via GitGitGadget, Jul 17, 2018
  22. 2/2 repack -ad: prune the list of shallow commitsJohannes Schindelin via GitGitGadget, Jul 17, 2018
  23. Eric SunshineJul 17, 2018
  24. Jeff KingJul 17, 2018
  25. Jeff KingJul 17, 2018
  26. Johannes SchindelinJul 19, 2018
  27. 0/3 repack -ad: fix after fetch --prune in a shallow repositoryJohannes Schindelin via GitGitGadget, Oct 22, 2018
  28. 1/3 repack: point out a bug handling stale shallow infoJohannes Schindelin via GitGitGadget, Oct 22, 2018
  29. Junio C HamanoOct 24, 2018
  30. Johannes SchindelinOct 24, 2018
  31. Johannes SchindelinOct 24, 2018
  32. 2/3 shallow: offer to prune only non-existing entriesJohannes Schindelin via GitGitGadget, Oct 22, 2018
  33. Junio C HamanoOct 24, 2018
  34. Johannes SchindelinOct 24, 2018
  35. Johannes SchindelinOct 24, 2018
  36. Jonathan TanOct 25, 2018
  37. Johannes SchindelinOct 26, 2018
  38. Jonathan TanOct 26, 2018
  39. Johannes SchindelinOct 29, 2018
  40. 3/3 repack -ad: prune the list of shallow commitsJohannes Schindelin via GitGitGadget, Oct 22, 2018
  41. Junio C HamanoOct 24, 2018
  42. Johannes SchindelinOct 24, 2018
  43. Johannes SchindelinOct 23, 2018
  44. 0/3 repack -ad: fix after fetch --prune in a shallow repositoryJohannes Schindelin via GitGitGadget, Oct 24, 2018
  45. 1/3 repack: point out a bug handling stale shallow infoJohannes Schindelin via GitGitGadget, Oct 24, 2018
  46. 3/3 repack -ad: prune the list of shallow commitsJohannes Schindelin via GitGitGadget, Oct 24, 2018
  47. 2/3 shallow: offer to prune only non-existing entriesJohannes Schindelin via GitGitGadget, Oct 24, 2018

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.