Re: [PATCH v2 0/2] repack -ad: fix after `fetch --prune` in a shallow repository

From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Jul 19, 2018, 17:48 UTC
Message-ID: <nycvar.QRO.7.76.6.1807191946090.71@tvgsbejvaqbjf.bet>
In-Reply-To: <20180717192002.GB30594@sigill.intra.peff.net>

Hi Peff,

On Tue, 17 Jul 2018, Jeff King wrote:

Show 16 quoted lines

> On Tue, Jul 17, 2018 at 03:15:31PM -0400, Jeff King wrote:
> 
> > > - Also trigger `prune_shallow()` when `--unpack-unreachable=<approxidate>` was passed to `git repack`.
> > > - No need to trigger `prune_shallow()` when `git repack` was called with `-k`.
> > 
> > I think you might have missed the bigger problem I pointed at, as it was
> > buried deep within my later reply. Try applying this patch on top, which
> > tests the opposite case (reachable shallow commits are retained):
> 
> By the way, I notice that the patches themselves are cc'd to you, but
> the cover letter isn't. So my reply went only to gitgitgadget, which
> (AFAIK) has not yet learned to work as a mail-to-comment gateway.
> 
> So I'm copying this to you directly to make sure you see it, but also
> because I'm not sure if the gitgitgadget cc behavior is intentional or
> not.

It is one of the existing TODOs to Cc: the person who hit "/submit". So I am aware of it, and it is recorded in the TODO.md file.

But as the GitHub user might not be associated with a public email, this will need an internal map that will be extended to whoever is in the list of allowed users.

Ciao, Dscho