Re: 2.18.0 Regression: packing performance and effectiveness
Junio C Hamano <gitster@pobox.com> writes:
Show 7 quoted lines
> Imagine that you create a delta and set its size (which happens to
> fit in the entry) and then create another whose size does not fit in
> the entry. How does oe_delta_size() know not to look at
> pack->delta_size[] and instead look at e->delta_size_ when it wants
> to know the delta for the first one? IOW, shouldn't there be a
> "backfill" procedure when oe_set_delta_size() notices that we now
> switch to pack->delta_size[] array?
Ah, ignore this. That is what happens in the prepare_ thing.
Junio C Hamano <gitster@pobox.com>