Re: [GSoC][PATCH 1/2] sequencer: add NULL checks under read_author_script
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 15, 2019, 18:04 UTC
- Message-ID
- <xmqqh87n41iv.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <20190712185357.21211-2-rohit.ashiwal265@gmail.com>
Rohit Ashiwal <rohit.ashiwal265@gmail.com> writes:
Show 13 quoted lines
> + if (name) > + *name = kv.items[name_i].util; > + else > + free(kv.items[name_i].util); > + if (email) > + *email = kv.items[email_i].util; > + else > + free(kv.items[email_i].util); > + if (date) > + *date = kv.items[date_i].util; > + else > + free(kv.items[date_i].util); > retval = 0;
Some of the .util field may have been freed and others may have taken possession by the caller at this point.
> finish: > string_list_clear(&kv, !!retval);
And we tell string_list_clear() not to free the .util field, so kv.items[].util won't leak, which is good.