Re: [GSoC][PATCH 2/2] rebase -i: support --committer-date-is-author-date

From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
Date: Jul 14, 2019, 11:31 UTC
Message-ID: <20190714113117.11748-1-rohit.ashiwal265@gmail.com>
In-Reply-To: <20190712185357.21211-3-rohit.ashiwal265@gmail.com>

On Sat, 13 Jul 2019 00:23:57 +0530 Rohit Ashiwal <rohit.ashiwal265@gmail.com> wrote:

Show 14 quoted lines

>
> rebase am already has this flag to "lie" about the committer date
> by changing it to the author date. Let's add the same for
> interactive machinery.
>
> Signed-off-by: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
> [...]
>
> +test_expect_success '--committer-date-is-author-date works with interactive backend' '
> +	git rebase -f HEAD^ &&
> +	git cat-file commit HEAD | sed -e "/^\$/q" >head &&
> +	sed -ne "/^author /s/.*> //p" head >authortime &&
> +	sed -ne "/^committer /s/.*> //p" head >committertime &&
> +	! test_cmp at ct &&

                   ^~~^~~~~
Slight mistake in changing names, I'll change it after a full review,
please ignore till then.

Show 5 quoted lines

> +	git rebase -i --committer-date-is-author-date HEAD^ &&
> +	git cat-file commit HEAD | sed -e "/^\$/q" >head &&
> +	sed -ne "/^committer /s/.*> //p" head >committertime &&
> +	test_cmp authortime committertime
> +'

We should also include a test for am backend since the flag is not directly passed to the am after the application of this patch.

> +
>  test_done
> --
> 2.21.0

Best Rohit