Re: [GSoC][PATCH v2 1/1] rebase -i: add --ignore-whitespace flag

From: Rohit Ashiwal <rohit.ashiwal265@gmail.com>
Date: Jul 23, 2019, 19:59 UTC
Message-ID: <20190723195932.16951-1-rohit.ashiwal265@gmail.com>
In-Reply-To: <xmqq5znxvhdu.fsf@gitster-ct.c.googlers.com>

Hi Junio

On Fri, 19 Jul 2019 14:33:49 -0700 Junio C Hamano <gitster@pobox.com> wrote:

> 
> >  t/t3431-rebase-options-compatibility.sh | 66 +++++++++++++++++++++++++
> 
> Isn't 3431 already taken?

It is not in git/git[1].

Show 21 quoted lines

> >  5 files changed, 97 insertions(+), 6 deletions(-)
> >  create mode 100755 t/t3431-rebase-options-compatibility.sh
> > ...
> > +	git checkout --orphan master &&
> > +	q_to_tab >file <<-EOF &&
> > +	line 1
> > +	        line 2
> > +	line 3
> > +	EOF
> 
> This will trigger "indent-with-space".  Instead of using q-to-tab,
> perhaps something like this would be more appropriate (not limited
> to this piece, but also other ones in this script that actually do
> use Q to visualize a tab)?
> 
> 	sed -e "s/^|//" >file <<-EOF &&
> 	|line 1
> 	|        line 2
> 	|line 3
> 	EOF
>

Oh! My mistake, I should have used cat instead.

Thanks Rohit

[1]: https://github.com/git/git/tree/master/t