From: Junio C Hamano Date: Mon, 09 Sep 2019 18:32:55 GMT Subject: Re: [PATCH 0/2] Date test code clean-up Message-ID: In-Reply-To: <20190909014711.3894-1-ischis2@cox.net> "Stephen P. Smith" writes: > As part of a previous patch submission[1], a cleanup patch was > suggested to remove a now unnecessary passing of a date environment > variable to the production code. It looks like that the idea to realize that get_time() that is aware of GIT_TEST_DATE_NOW is always called before functions like show_date_relative(), approxidate_str() and approxidate_careful(), and arrange it to be called in the lower level of the callchain, which makes sense to me. Thanks for tying the loose end.