Re: [PATCH v2 18/24] gpg-interface: improve interface for parsing tags
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Feb 25, 2020, 19:25 UTC
- Message-ID
- <xmqqh7zemptx.fsf@gitster-ct.c.googlers.com>
- In-Reply-To
- <nycvar.QRO.7.76.6.2002251127320.46@tvgsbejvaqbjf.bet>
Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
Show 9 quoted lines
>> /* parse signature first; we might not even have a subject line */ >> - *sig = buf + parse_signature(buf, strlen(buf)); >> - *siglen = strlen(*sig); >> + parse_signature(buf, end - buf, &payload, &signature); >> + *sig = strbuf_detach(&signature, siglen); > > While I like the spirit of this patch, it makes the Windows build fail. I > put this on top of Git for Windows' `shears/pu` branch to fix it (maybe > you could adopt a variation of it?):
FWIW, it's of course not just Windows, but on anything whose size_t != ulong, e.g. https://travis-ci.org/git/git/jobs/654661788 (Linux32)