Re: [PATCH v2 18/24] gpg-interface: improve interface for parsing tags

From: brian m. carlson <sandals@crustytoothpaste.net>
Date: Feb 26, 2020, 03:05 UTC
Message-ID: <20200226030545.GD7911@camp.crustytoothpaste.net>
In-Reply-To: <xmqqh7zemptx.fsf@gitster-ct.c.googlers.com>

On 2020-02-25 at 19:25:46, Junio C Hamano wrote:

Show 14 quoted lines

> Johannes Schindelin <Johannes.Schindelin@gmx.de> writes:
> 
> >>  	/* parse signature first; we might not even have a subject line */
> >> -	*sig = buf + parse_signature(buf, strlen(buf));
> >> -	*siglen = strlen(*sig);
> >> +	parse_signature(buf, end - buf, &payload, &signature);
> >> +	*sig = strbuf_detach(&signature, siglen);
> >
> > While I like the spirit of this patch, it makes the Windows build fail. I
> > put this on top of Git for Windows' `shears/pu` branch to fix it (maybe
> > you could adopt a variation of it?):
> 
> FWIW, it's of course not just Windows, but on anything whose size_t
> != ulong, e.g. https://travis-ci.org/git/git/jobs/654661788 (Linux32)

I will likely not get to a reroll before Thursday at the earliest due to other commitments, so if it's more convenient for you to eject this from pu and just pick up v3 when I get around to it, please feel free.

-- 
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204