Re: [PATCH v2 0/7] remote-curl: fix deadlocks when remote server disconnects

From: Junio C Hamano <gitster@pobox.com>
Date: May 18, 2020, 19:36 UTC
Message-ID: <xmqqh7wd2fyk.fsf@gitster.c.googlers.com>
In-Reply-To: <20200518165056.GD42240@coredump.intra.peff.net>

Jeff King <peff@peff.net> writes:

> Overall this looks pretty cleanly done. I left a few minor comments
> throughout, but the real question is whether we prefer the "0002" packet
> in the last one, or if we instead insist that the response end in a
> flush.

Thanks for a review. I was reading the series through and I found it a reasonably pleasant read.

> So I think either of your solutions (enforcing a final flush, or the
> 0002 packet) is preferable. I'm on the fence between them.

I am undecided, too X-<.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.