Re: [PATCH] commit-graph: add verify changed paths option
- From
Junio C Hamano <gitster@pobox.com>
- Date
- Jul 31, 2020, 17:14 UTC
- Message-ID
- <xmqqh7tn4neo.fsf@gitster.c.googlers.com>
- In-Reply-To
- <pull.687.git.1596181765336.gitgitgadget@gmail.com>
"Son Luong Ngoc via GitGitGadget" <gitgitgadget@gmail.com> writes:
Show 5 quoted lines
> From: Son Luong Ngoc <sluongng@gmail.com> > > Add '--has-changed-paths' option to 'git commit-graph verify' subcommand > to validate whether the commit-graph was written with '--changed-paths' > option.
The implementation seems to be only about "does this section exist?" and not "does this section have healthy/uncorrupted data?", which feels a bit strange for "verify". Instead of setting ourselves up to having to add "--has-this-section" and "--has-that-section" every time a new kind of data is added to the system, how about giving the verify command an option to list all the sections found in the file, or a separate "git commit-graph list-sections" subcommand?