git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] commit-graph: add verify changed paths option

From
Son Luong Ngoc <sluongng@gmail.com>
Date
Jul 31, 2020, 19:31 UTC
Message-ID
<E6157D6A-52FB-4E0D-BFE7-8F3B0848F8A3@gmail.com>
In-Reply-To
<20200731191448.GA848793@coredump.intra.peff.net>
Note: re-send  to mailing list due to me forgot to turn on Plain Text format.
(sorry for the noise)
Hi Peff, Taylor, Junio and Christian,

Thanks a lot for the valuable feedbacks. This is exactly what I was hoping for by sending out the patch early!

Show 26 quoted lines
> On Jul 31, 2020, at 21:14, Jeff King <peff@peff.net> wrote:
> 
> On Fri, Jul 31, 2020 at 02:09:56PM -0400, Taylor Blau wrote:
> 
>>> Is a single boolean flag sufficient? If you have incrementals, you might
>>> have some slices with this chunk and some without. What should the
>>> boolean be in that case?
>> 
>> I think you'd really want to know which layers do and don't have
>> filters. It might be even more interesting to have a tool like what 'git
>> show-index' is to '*.idx' files, maybe something like 'git show-graph'
>> or 'git show-commit-graph'. Its output would be one line per commit that
>> shows:
>> 
>>  - what layer in the chain it's located at
>>  - its graph_pos
>>  - its generation number
>>  - whether or not it has a Bloom filter
>>  - ???
>> 
>> That would be a useful tool for debugging anyway, even outside of the
>> test suite. It would be even better if we could replace the test-tool
>> with it.
> 
> Yeah, that was exactly what I had in mind, except that I'd make it a
> sub-command of "git commit-graph" ("show" or perhaps "dump").

I loved Junio's initial suggestion and the follow up here. I was thinking of something like 'git commit-graph verify --verbose' but now I agree that a distinct command such as 'show' might be more distinct and better communicate the purpose.

I will stick with my poor-man bash/golang script for now to invalidate the commit-graph (chain or no-chain) as it does the job just fine.

Let me see if I have the capacity to implement 'show' sub-command after. ^_^!

> 
> -Peff

Cheers, Son Luong.

Previous: Jeff King
Message 8 of 8 in “commit-graph: add verify changed paths option”
  1. commit-graph: add verify changed paths optionSon Luong Ngoc via GitGitGadget, Jul 31, 2020
  2. Christian CouderJul 31, 2020
  3. Junio C HamanoJul 31, 2020
  4. Taylor BlauJul 31, 2020
  5. Jeff KingJul 31, 2020
  6. Taylor BlauJul 31, 2020
  7. Jeff KingJul 31, 2020
  8. Son Luong NgocJul 31, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.