Re: [PATCH] commit-graph: add verify changed paths option
- From
Jeff King <peff@peff.net>
- Date
- Jul 31, 2020, 19:14 UTC
- Message-ID
- <20200731191448.GA848793@coredump.intra.peff.net>
- In-Reply-To
- <20200731180956.GA60133@syl.lan>
On Fri, Jul 31, 2020 at 02:09:56PM -0400, Taylor Blau wrote:
Show 19 quoted lines
> > Is a single boolean flag sufficient? If you have incrementals, you might > > have some slices with this chunk and some without. What should the > > boolean be in that case? > > I think you'd really want to know which layers do and don't have > filters. It might be even more interesting to have a tool like what 'git > show-index' is to '*.idx' files, maybe something like 'git show-graph' > or 'git show-commit-graph'. Its output would be one line per commit that > shows: > > - what layer in the chain it's located at > - its graph_pos > - its generation number > - whether or not it has a Bloom filter > - ??? > > That would be a useful tool for debugging anyway, even outside of the > test suite. It would be even better if we could replace the test-tool > with it.
Yeah, that was exactly what I had in mind, except that I'd make it a sub-command of "git commit-graph" ("show" or perhaps "dump").
-Peff