git/list[1] front-page[2] threads[3] people[4] search[5] about
 

Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build

From
Junio C Hamano <gitster@pobox.com>
Date
Nov 2, 2020, 18:55 UTC
Message-ID
<xmqqh7q7vbah.fsf@gitster.c.googlers.com>
In-Reply-To
<6676a08d-0c25-14ba-4ea6-677bc7ab0e20@ramsayjones.plus.com>
Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> Yes, anybody who just does 'make sparse' will notice the failure, so
> that would be a definite improvement. (How many people run 'make sparse'
> though?).

At least, I was planning to add one to the number when I wrote the patch, so that I would start using it as part of daily integration build before pushing day's result out.

I can tweak my $(MAKE) command line arguments in the script I use for daily integration builds, so the patch is not strictly needed for me personally.

> I guess it would be most useful on a CI build, but I don't know what
> would be involved in setting that up.

CI builds already have enough stuff around invocation of "make test" etc., and it would be trivial to pass SPARSE_FLAGS from the command line when adding "make sparse" invocation to one of the scripts in ci/ directory, so from that point of view, this patch is not needed for them, either.

My hope was that it would make it harder for individual contributors who run "make sparse" and fail to notice an error from it.

Previous: Ramsay JonesNext: Ramsay Jones
Message 4 of 11 in “upload-pack.c: fix a sparse warning”
  1. upload-pack.c: fix a sparse warningRamsay Jones, Oct 31, 2020
  2. Makefile: enable -Wsparse-error for DEVELOPER buildJunio C Hamano, Oct 31, 2020
  3. Ramsay JonesNov 2, 2020
  4. Junio C HamanoNov 2, 2020
  5. Ramsay JonesNov 3, 2020
  6. Junio C HamanoNov 3, 2020
  7. Johannes SchindelinNov 4, 2020
  8. Ramsay JonesNov 4, 2020
  9. Junio C HamanoNov 4, 2020
  10. Ramsay JonesNov 4, 2020
  11. Josh SteadmonNov 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.