Re: [PATCH] Makefile: enable -Wsparse-error for DEVELOPER build

From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Nov 3, 2020, 02:04 UTC
Message-ID: <43aadae9-a4c1-f1e4-6902-c05af36fcf19@ramsayjones.plus.com>
In-Reply-To: <xmqqh7q7vbah.fsf@gitster.c.googlers.com>

On 02/11/2020 18:55, Junio C Hamano wrote:

Show 9 quoted lines

> Ramsay Jones <ramsay@ramsayjones.plus.com> writes:
> 
>> Yes, anybody who just does 'make sparse' will notice the failure, so
>> that would be a definite improvement. (How many people run 'make sparse'
>> though?).
> 
> At least, I was planning to add one to the number when I wrote the
> patch, so that I would start using it as part of daily integration
> build before pushing day's result out.

Great! :-D

How are you installing sparse? (I am using Linux Mint 20, based on Ubuntu 20.04, whose sparse package version is 0.6.1-2build1 - which is to say too old; you require version 0.6.2 or greater. Building from source, I am currently using v0.6.3-76-gf680124b).

[I seem to remember you saying you used Fedora, which usually has more up-to-date software than most distros].

Show 8 quoted lines

>> I guess it would be most useful on a CI build, but I don't know what
>> would be involved in setting that up.
> 
> CI builds already have enough stuff around invocation of "make test"
> etc., and it would be trivial to pass SPARSE_FLAGS from the command
> line when adding "make sparse" invocation to one of the scripts in
> ci/ directory, so from that point of view, this patch is not needed
> for them, either.

My concern was more about how the CI system obtains/installs/builds a sufficiently new version of sparse. Otherwise, 'make sparse' won't do very much. ;-) As I said, I don't know what's involved in getting that to work.

ATB, Ramsay Jones