git/list[1] front-page[2] threads[3] people[4] search[5] about
 

[PATCH] upload-pack.c: fix a sparse warning

From
Ramsay Jones <ramsay@ramsayjones.plus.com>
Date
Oct 31, 2020, 21:04 UTC
Message-ID
<eaf5ac83-af3f-5028-3a9e-1669c9cde116@ramsayjones.plus.com>
Signed-off-by: Ramsay Jones <ramsay@ramsayjones.plus.com>
---
Hi Josh,

If you need to re-roll your 'js/trace2-session-id' branch, could you please squash this into the relevant patch (commit edb21a501e, "upload-pack, serve: log received client trace2 SID", 29-10-2020).

Thanks!
ATB,
Ramsay Jones
 
 upload-pack.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/upload-pack.c b/upload-pack.c
index b7d097bf1b..2996b8083c 100644
--- a/upload-pack.c
+++ b/upload-pack.c
@@ -1111,7 +1111,7 @@ static void receive_needs(struct upload_pack_data *data,
 		if (data->allow_filter &&
 		    parse_feature_request(features, "filter"))
 			data->filter_capability_requested = 1;
-		if ((arg = parse_feature_value(features, "trace2-sid", &feature_len, 0)))
+		if ((arg = parse_feature_value(features, "trace2-sid", &feature_len, NULL)))
 		{
 			char *client_sid = xstrndup(arg, feature_len);
 			trace2_data_string("trace2", NULL, "client-sid", client_sid);
-- 
2.29.0
Next: Junio C Hamano
Message 1 of 11 in “upload-pack.c: fix a sparse warning”
  1. upload-pack.c: fix a sparse warningRamsay Jones, Oct 31, 2020
  2. Makefile: enable -Wsparse-error for DEVELOPER buildJunio C Hamano, Oct 31, 2020
  3. Ramsay JonesNov 2, 2020
  4. Junio C HamanoNov 2, 2020
  5. Ramsay JonesNov 3, 2020
  6. Junio C HamanoNov 3, 2020
  7. Johannes SchindelinNov 4, 2020
  8. Ramsay JonesNov 4, 2020
  9. Junio C HamanoNov 4, 2020
  10. Ramsay JonesNov 4, 2020
  11. Josh SteadmonNov 2, 2020

Read the whole thread, see it on lore, or plain text.

$ cat FOOTERMessages come from the public archive at lore.kernel.org/git, fetched every hour. The front page is chosen and written each morning by an AI editor and can be wrong; the threads themselves are the record. About and API. For agents: an MCP server at https://gitlist.dev/mcp, and any thread, story or person page as Markdown by adding .md to its URL (or sending Accept: text/markdown). Details in /llms.txt.