Re: [PATCH v3 00/27] Compile with `-Wwrite-strings`
Patrick Steinhardt <ps@pks.im> writes:
Show 5 quoted lines
> Changes compared to v2:
>
> - I have split up the second patch into multiple patches. This was
> done so that we can have a deeper look at the respective sites that
> need adjustment.
We will see how well this helps reviewer.
Show 5 quoted lines
> - I dropped the local string arrays that I used in v2 and instead now
> use string constants with casts in some places where we expect that
> those should never be written to. This has the benefit that we would
> segfault in case that expectation is violated, instead of silently
> allowing a write to those local arrays.
> - I adapted multiple commit messages to not only mention freeing of
> string constants, but also that writing to string constants is
> illegal.
> Due to the split-up patch the range-diff got quite messy and was barely
> readable anymore. I thus included an interdiff instead, which should be
> way easier to read.
Junio C Hamano <gitster@pobox.com>